search

cunybpl / aiodal

async data access layer and related tools for sqlalchemy core
0 stars 0 forks source link

Add generic connect module #6

Closed kgasiorowski closed 11 months ago

kgasiorowski commented 11 months ago

Generic module to assist with connecting to a db instance using aiodal.

kgasiorowski commented 11 months ago

I think what I've added here should work, but I wanted to add maybe a couple test cases to be sure.

I was hoping to use the pytest-mock the same way I did in beist (https://github.com/cunybpl/beist/blob/development/tests/test_app.py#L57) so we didn't actually attempt to connect to any databases, but it doesn't seem to be set up in aiodal.

If you don't care about the test cases you can merge it as-is, but otherwise I could use some help setting up the mocker fixture in pytest. I've tried poetry add pytest-mock to the project and re-building but that doesn't work. I looked through the testing configuration and the poetry files in beist to check for anything special regarding the mocker but I couldn't find anything. So, any kind of direction would be much appreciated @bsnacks000

bsnacks000 commented 11 months ago

@kgasiorowski always time for more tests... do poetry add pytest-mock -G dev so it lands in the dev deps.