search

cunybpl / sendgrid_client

A simple client/email backend wrapper for bulk emailing with sendgrid
0 stars 0 forks source link

Finish boilerplate #2

Closed kgasiorowski closed 1 year ago

kgasiorowski commented 1 year ago
kgasiorowski commented 1 year ago

mypy was complaining about sendgrid so I tried twilio instead and that seemed to work - let me know what you think @bsnacks000 ?

Anyway this should take care of all the boilerplate so just take a look over it and merge if you like

bsnacks000 commented 1 year ago

I looked through twilio package and I didn't see a way to send emails via sendgrid unless i'm missing something.. Is there something I missed in the docs? I know the other lib will work since we've used it with django for years...

If its only a mypy thing then I think we can just type: ignore their import statements and it will shut up mypy... we can do our own types.

kgasiorowski commented 1 year ago

Yeah, sorry about that - looks like sendgrid works, I just needed to add the twilio stubs package to stop mypy from complaining. Take another look whenever @bsnacks000