search

cuongdevjs / reactjs-social-login

Group Hook ReactJS components for login social network
https://react-social-login.netlify.app
MIT License
172 stars 76 forks source link

Google not fully reporting back some errors #127

Closed franciscopaglia closed 1 year ago

franciscopaglia commented 1 year ago

Describe the bug Currently, when a non-Oauth error occurs in the Google flow (eg: The user closes the modal), no callback will be triggered by the Google component. Other components like Facebook and Apple do account for these cases in this same project.

Expected behavior An error should be reported back to the client, at least to let the client know that the modal was closed.

Additional context Already opened a PR to fix the issue #118, @cuongdevjs could you please review it?

cuongdevjs commented 1 year ago

Thank you so much. I appreciate it. I'll take a look at it this weekend.

cuongdevjs commented 1 year ago

The PR #118 merged and released. Thank you so much. I appreciate it

franciscopaglia commented 1 year ago

Thanks for your time @cuongdevjs, really appreciated!