search

cuongdevjs / reactjs-social-login

Group Hook ReactJS components for login social network
https://react-social-login.netlify.app
MIT License
172 stars 76 forks source link

Facebook Bussiness Login config_id added #132

Closed narayanmettle closed 1 year ago

narayanmettle commented 1 year ago

I have added a config_id for the facebook login for the business type login

narayanmettle commented 1 year ago

That I have used for internal uses and forgot to revert it back.

On Sat, 16 Sep 2023 at 1:51 PM, Nguyen Manh Cuong @.***> wrote:

@.**** commented on this pull request.

why do you remove dist in gitignore?

— Reply to this email directly, view it on GitHub https://github.com/cuongdevjs/reactjs-social-login/pull/132#pullrequestreview-1629926147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZATBURCJVROYJVWZ4BIMDX2VOR5ANCNFSM6AAAAAA4XOMYLI . You are receiving this because you authored the thread.Message ID: @.***>

cuongdevjs commented 1 year ago

please remove unnecessary changed files and follow the file format. There are some redundant commits, although I appreciate your contribution but this doesn't guarantee the code standard.

narayanmettle commented 1 year ago

Once I remove the other commits rather than the config_id change hope it’s good to go for the pull merge. What do you think? We need the solution.

On Sun, 17 Sep 2023 at 11:39 AM, Nguyen Manh Cuong @.***> wrote:

Closed #132 https://github.com/cuongdevjs/reactjs-social-login/pull/132.

— Reply to this email directly, view it on GitHub https://github.com/cuongdevjs/reactjs-social-login/pull/132#event-10390838119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZATBWDXUEDHYWCJL6JKYLX22HYNANCNFSM6AAAAAA4XOMYLI . You are receiving this because you authored the thread.Message ID: @.*** com>

cuongdevjs commented 1 year ago

yep, please create a new PR with only the necessary changed file, and make sure you follow the formatting code that currently it has. Thank you.

narayanmettle commented 1 year ago

Okay, thank you! I will do that and please merge that request. Thanks again

On Sun, 17 Sep 2023 at 12:01 PM, Nguyen Manh Cuong @.***> wrote:

yep, please create a new PR with only the necessary changed file, and make sure you follow the formatting code that currently it has. Thank you.

— Reply to this email directly, view it on GitHub https://github.com/cuongdevjs/reactjs-social-login/pull/132#issuecomment-1722405652, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZATBRQ2RPVYSL7ZNICNWLX22KLFANCNFSM6AAAAAA4XOMYLI . You are receiving this because you authored the thread.Message ID: @.***>