search

cuongpl / capacitor-ios-autofill-save-password

Prompt to display dialog for saving password to keychain for iOS webview app.
8 stars 10 forks source link

Support for Capacitor 3 #1

Closed nunoarruda closed 3 years ago

nunoarruda commented 3 years ago

Hi @cuongpl,

Thanks for the handy plugin 👍. This plugin breaks Xcode builds when using Capacitor 3. Do you want to update it to support Capacitor 3?

It looks like @EliArtist partially did it on the fork https://github.com/EliArtist/capacitor-ios-autofill-save-password but I thought to open an issue anyway in case you want to update the plugin in the "official" repo.

TypeScript support would be nice too since the Plugins object is deprecated.

Thanks!

cuongpl commented 3 years ago

@nunoarruda Of course I want to update to support Capacitor 3 and TypeScript. Can you please send me a pull request?

nunoarruda commented 3 years ago

@cuongpl sorry, I'm a web developer. I have no knowledge of native programming and plugin development. Maybe the following resource might help you update the plugin?

cuongpl commented 3 years ago

@nunoarruda Thanks for your information. Actually I created this plugin for a company project and it ended a long time ago. I no longer have macOS environment to continue my plugin development. I will update it as soon as I can.

EliArtist commented 3 years ago

Just created a pull request, maybe that makes things a little easier for you :) https://github.com/cuongpl/capacitor-ios-autofill-save-password/pull/2

cuongpl commented 3 years ago

@EliArtist Thanks for your pull request. I've merged it.

cuongpl commented 3 years ago

@nunoarruda Maybe it works on Capacitor 3 now so I close this issue.