Callins should not occur on synthetic callbacks

[ftc]

When instrumenting a trace there are 4 steps:

• Override all overrideable methods
• Instrument all callins
• Instrument all callbacks
• Insturment all Exceptions

This ordering means that the required super call from the override all overrideable methods is logged as a callin when the application never made this callin.

Corner case: if an overridden method is called as a callin from the application we still need to log it as a callin. The current mechanism looks at where the call resolves to and if its framework its logged, this doesn't work with the override so look into how to make this work.

Possible solution: reorder as follows:

• Instrument all callins
• Override all overrideable methods
• Instrument all callbacks
• Insturment all Exceptions

And then make sure that calling a method from the app that has been overridden still logs as callin.

[58] [CB] void plv.colorado.edu.mediaplayerexample.MainActivity.onCreate(android.os.Bundle) (17252cf4,NULL) 
  [59] [CI] void android.support.v7.app.AppCompatActivity.onCreate(android.os.Bundle) (17252cf4,NULL) 
  [60] [CB] android.support.v7.app.AppCompatDelegate plv.colorado.edu.mediaplayerexample.MainActivity.getDelegate() (17252cf4) 
  [61] [CI] android.support.v7.app.AppCompatDelegate android.support.v7.app.AppCompatActivity.getDelegate() (17252cf4) 
  [62] [CB] android.view.Window plv.colorado.edu.mediaplayerexample.MainActivity.getWindow() (17252cf4) 
  [63] [CI] android.view.Window android.app.Activity.getWindow() (17252cf4) 
  [66] [CB] android.content.res.Resources$Theme plv.colorado.edu.mediaplayerexample.MainActivity.getTheme() (17252cf4) 
  [67] [CI] android.content.res.Resources$Theme android.view.ContextThemeWrapper.getTheme() (17252cf4) 
  [70] [CB] android.content.res.Resources plv.colorado.edu.mediaplayerexample.MainActivity.getResources() (17252cf4) 
  [71] [CI] android.content.res.Resources android.support.v7.app.AppCompatActivity.getResources() (17252cf4) 
  [74] [CB] android.content.res.Resources$Theme plv.colorado.edu.mediaplayerexample.MainActivity.getTheme() (17252cf4) 
  [75] [CI] android.content.res.Resources$Theme android.view.ContextThemeWrapper.getTheme() (17252cf4) 

[ftc]

• [ ] Figure out how to check for automatically overridden callback
• [ ] Don't instrument super call if so
• [ ] Update code for instrumenting callins to handle this

[ftc]

Discussion Dec 19 with Evan Sergio Shawn and Edmund:

Upshot is that the super call should be left in as this is the desired behavior.

Arguments for keeping the callins:

• If something takes effect on the framework when super is called then we want to match the call to super specifically.
• Showing a callback without the super callin may mean we need special case rules to say "if onCreate is artificially overridden then don't require the super call" if super calls were included in lifestate verification.
• The rules can be written as to ignore these if they are not needed for the verification.

Arguments for removing the callins:

• The trace can observe callins which were never specified in the origional program.

My suggestion action: Leave super calls but label "artificial" callbacks in the trace so if we decide to change the behavior later retracing is not necessary.