search

cupshir / homebridge-aqua-connect-lite

A Homebridge plugin that exposes limited functionality of Aqua Connect to Homekit.
GNU General Public License v3.0
4 stars 3 forks source link

Aux 1-6 and Pool Light Status #9

Open brianp9906 opened 1 year ago

brianp9906 commented 1 year ago

Hello My Pool Light Status shows Key 5, not 4 so it doesnt properly show the pool status in Homebridge. Also I have Aux 1-6 so I was attempting to fork and make changes and submit a PR. Do you have guidance on how I can test changes locally on homebridge? thank you

cupshir commented 1 year ago

If you fork the repo, then run 'npm install' command in the root directory, it should install everything needed to run locally, including homebridge.

After 'npm install', run 'npm run watch' command. It will build the project and the start everything up. the terminal output should show what the url is to access the admin interface. Keep in mind, this is only a barebones homebridge so something might be missing or dont work.

Side note, i dont think i will be able to merge in the changes if you submit a PR as that will then break the plugin for the rest of us. If you want to do a PR change, then you would need to build in a way to override the process_key_num and status_key_index from the plugin settings, quite a bit more involved.

Side side note, in my testing a few months back with trying to implement heater functionality, I started to see performance issues. Having 6 aux might cause problems with the plugin in its current state.

brianp9906 commented 1 year ago

Thank you for the detail and guidance. I find it interesting that the pool light key/index is different. Screenshot from my web console with Firefox debug when I did an inspect on the "Lights" button.

image

I was able to get it working adding all the aux accessories. I dont use them all so I may exclude some of them to reduce performance issues. I see in your readme that you plan to add support to override the key status/index key values. Have you start that in a branch somewhere?

Just asking since I'm enjoying the reliability of this homebridge accessory (over the Aqua iOS app which has lots of delay) and want to help contribute back where I can be of help.