curaOS / source

Start a solid foundation of tools for creators+builders.
https://cura.run
15 stars 13 forks source link

Added new buttons styles #123

Closed sekaiking closed 2 years ago

sekaiking commented 2 years ago

closes #112

Added the following buttons styles

Removed the following buttons styles

Updated buttons stories

check https://60d9b2ac2cf86a00396f9b0f-imlsmwwdrx.chromatic.com/?path=/story/elements-button--primary

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/7TCYhzNqeA1CXjgqCyBJD7tJNDXp
✅ Preview: https://frontend-git-wipdesignupdate-curaos.vercel.app

sekaiking commented 2 years ago

The only difference between examples/frontend/theme.ts and packages/components/theme.ts is a style object which is applied globally to the website. We can't have that in components theme because it will affect the whole website where components are used.

I used it to define the default styles of the pages, that doesn't rely on components. Like the background color, and typography stuff will make sure the website has consistent text styles, even if in future we added something without components.

This is the only difference between them:

    styles: {
        root: {
            variant: `text.body`,
            bg: `bg`,
        },
        a: {
            variant: `text.buttons.1`,
        },
    },

We can remove them for now, and add them as necessary after components are done being updated, if that makes it simpler.

bestatigen commented 2 years ago

@achrafismyname understood. Thanks for the clarification, you can leave it!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version @cura/components-v1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: