curaOS / source

Start a solid foundation of tools for creators+builders.
https://cura.run
15 stars 13 forks source link

Components + Frontend | Design update #175

Closed sekaiking closed 2 years ago

sekaiking commented 2 years ago

I think the design is finally done Latest working live preview: https://frontend-git-darkmode-curaos.vercel.app/

Closes #98

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/3kDpftAb9cCVsAMHQ4xUcy8dG9DF
✅ Preview: https://frontend-git-designupdate-curaos.vercel.app

sekaiking commented 2 years ago

For reviewing, I suggest starting with components and see how the folder structure changed a bit, then theme.ts which has most styling values, then you can review each component individually.

After components is clear, check how theme and fonts is imported in frontend then how I changed the pages to rely on layouts instead of eaching one having thier own styles. Then finalyl you can review each layout individually.

And I think that's it, it seems like a big PR but most changes are not criticial because most changes are CSS and if the overall structure is not broken then it's all good.

I'll also do a browser review, to check if everything looks good in all modern browsers/screens.

sekaiking commented 2 years ago

Description

This PR updates the design of both components and frontend by updating styles in theme.ts and changing the layout inside components and page so they work together properly. I tried to make it as themable as possible, so the styles that affect the look and feel are all inside theme.ts. And the styles that affect the layout (order, padding, margins...) are defined inside the component itself.

Fixes #98

Type of change

How Has This Been Tested?

Because this change is aimed for design more than functionality, I tested like the following:

Checklist:

Notes:

I think that's is it, hopefully :)

bestatigen commented 2 years ago

@achrafismyname bumped components but got this now:

ModuleNotFoundError: Module not found: Error: Can't resolve '@cura/components/dist/assets/fonts/index.css' in '/Users/yassinesania/Coding/Cura/examples/frontend/pages'
sekaiking commented 2 years ago

Hey @devey, From looking at the package here assets folder is missing. I tried bumping them to my own package here and didn't have this issue. I think something went wrong with the scripts that copy assets folder but I'm not sure why exactly.

Because you are in mac you can remove this line https://github.com/curaOS/source/blob/79aa546ce8582040d6533d6dcd47490f5a8e49b1/packages/components/package.json#L14

and replace it with something like this

 "copy-files": " cp -R  src/assets dist/assets", 
github-actions[bot] commented 2 years ago

:tada: This PR is included in version @cura/components-v1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: