search

curaOS / source

Start a solid foundation of tools for creators+builders.
https://cura.run
15 stars 13 forks source link

Frontend | adding NFT preview to claim_design #183

Closed sekaiking closed 2 years ago

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/CGUWWicHUdTHZeyJw82ANYhWhi62
✅ Preview: https://frontend-git-nftpreview-curaos.vercel.app

bestatigen commented 2 years ago

@achrafismyname I forgot to merge this first. 😌 Could you try to rebase it?

bestatigen commented 2 years ago

I guess to merge this @achrafismyname we also need to deploy new contracts for the contracts? Let's do that then we are done with cNFT on curaOS/contracts

sekaiking commented 2 years ago

@devey, it works but we'll fall into this issue #189. And we would have to detect the type of each URI before displaying it The issue is that for the old NFTs, media is still the iframe URI, and for the new NFTs minted using this PR are images.

But yeah, that's good idea. Let's keep it until we are done from cNFT, so we can give it a fresh start

sekaiking commented 2 years ago

moved to #194