search

curaOS / source

Start a solid foundation of tools for creators+builders.
https://cura.run
15 stars 13 forks source link

Fix packages #196

Closed sekaiking closed 2 years ago

sekaiking commented 2 years ago

links

overview

Now, when developing the @cura/components will use @cura/hooks from the local folder, but when published it will get replaced with latest version from NPM

And thanks to publishConfig, we can use the files from src/ in developement and replaced with dist/ when publishing

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/3RHjefMcRmFcYcuM9DcB3TkUcuir
✅ Preview: https://frontend-git-fixpackages-curaos.vercel.app

sekaiking commented 2 years ago

Hey @AshenI99, there was an issue before where when we used @cura/hooks inside @cura/components it will fail. (This issue were only happening when doing a clean install and deleting dist folder. )

The main component which was affected is NFTE, and Yassine disabled it, now I enabled it again and tried to fix it.

Can you please make sure it works for you and no other problems shows up.

Also now, I think when doing yarn dev:components, the hooks package should get hot reloaded. Can you make sure that works too.

Thank you :))

The original issue: https://github.com/curaOS/source/issues/114#issue-1048784645

github-actions[bot] commented 2 years ago

:tada: This PR is included in version @cura/hooks-v1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version @cura/components-v1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: