curationexperts / cypripedium

A Hyrax 3 application for the Federal Reserve Bank of Minneapolis
2 stars 3 forks source link

Remove dead code #566

Closed mark-dce closed 11 months ago

mark-dce commented 11 months ago

Hyrax calls a class named CharacterizeJob, not Hyrax::CharacterizeJob, so, we can remove the unused class.

References The relevant original PR https://github.com/curationexperts/cypripedium/pull/348/files

The relevant version of Hyrax (active at the time of the PR) https://github.com/samvera/hyrax/blob/v2.5.1/app/jobs/characterize_job.rb

To correctly override Hyrax, the file should be named CharacterizeJob and located at app/jobs/characterize_job.rb instead of Hyrax::CharacterizeJob located at app/jobs/hyrax/characterize_job.rb.

Since we appear to have been using the engine class all the time, this change removes the local code that is never called.