search

curationexperts / laevigata

A Hyrax-based ETD repository including deposit workflow
Other
5 stars 4 forks source link

[Maintenance] Always stub virus scanner #2376

Closed mark-dce closed 2 weeks ago

mark-dce commented 2 weeks ago

RATIONALE We're testing whether our code behaves correctly when ClamAV (via Clamby) detects a virus, not whether ClamAV is installed and working correctly. We need to have a different process in place to ensure ClamAV is working correctly in production anyway.

Shelling out to ClamAV during the test suite adds significant overhead that tells us about the environment rather than the application behavior.

This change ensures the tests just test whether our code behaves correctly when ClamAV is installed and running as expected.

coveralls commented 2 weeks ago

Coverage Status

coverage: 93.438%. remained the same when pulling 64c902affcb0317847e57ae69e64245e32e6d491 on nursing into 47ddcfb6253363a956ef311142bcc2ac6d00d8bd on main.