search

curationexperts / laevigata

A Hyrax-based ETD repository including deposit workflow
Other
5 stars 4 forks source link

[REFACTOR] Simplify authority service setup #2409

Closed mark-dce closed 1 month ago

mark-dce commented 1 month ago

RATIONALE The authority services contained a sinificant amount of duplicated code with only one initialization term differing in each class.

There was also configuration duplicated between the JavaScript front-end and services in the Rails application.

This change refactors the services to reduce duplicated code and to replace mapping logic with existing configuration files.

NOTE This refactoring also allows us to display School of Nursing information in the school dashboard witout having to add custom Woodruff program mappings in the LaevigataAuthorityService.

coveralls commented 1 month ago

Coverage Status

coverage: 94.221% (-0.01%) from 94.232% when pulling 4a274eab55258a3ead953c85a22c7d45b9435f4b on authorities into de0883a83983375df6a147ff7e24573b95a70764 on main.