search

curationexperts / laevigata

A Hyrax-based ETD repository including deposit workflow
Other
5 stars 4 forks source link

[REFACTOR] Remove unnecessary form code #2415

Closed mark-dce closed 1 month ago

mark-dce commented 1 month ago

ISSUE We previously provided code pathways for native Hyrax conroller updates if we were not using the JavaScript front-end, and separate processing for patches from the JavaScript front-end.

All user input now comes from the JavaScript front-end, so we no longer need to support multiple update pathways.

RESOLUTION Therefore, we can remove the request_from_form flag that triggers the JavaScript update pathway - i.e. all updates should now use that single update process.

coveralls commented 1 month ago

Coverage Status

coverage: 90.952% (-4.1%) from 95.066% when pulling 9669c1301c184e3c21f131ecf330639e0ec7c42e on etd_controller_coverage into 6d5be29d03ba09e1c7daf3b0c8fa38ed7a4bee65 on main.

mark-dce commented 1 month ago

Embargo management uses the ETD controller using rails forms, so this code turns out not to be obsolete.