curationexperts / laevigata

A Hyrax-based ETD repository including deposit workflow
Other
5 stars 4 forks source link

[MAINTENANCE] Remove legacy data format support #2429

Closed mark-dce closed 1 month ago

mark-dce commented 1 month ago

ISSUE At one point, the data model stored embargo flags in multiple formats. The data has since been normalized and all ETDs are populated with a TRUE/FALSE boolean value for each embargo flag.

An analysis of the current Solr index confirms this:

Further, the *_tesim values have been removed from the index (see supporting data below)

Therefore, we no longer require the datatype fallbacks impelmented to support the non-normalized data.

RESOLUTION Simplify the SolrDocument model by removing obsolete data type spport.

BOOLEANS

/ 20240923112632
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_bsi%3A*&facet.query=files_embargoed_bsi%3A*&facet.query=toc_embargoed_bsi%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 24,
    "params": {
      "facet.query": [
        "abstract_embargoed_bsi:*",
        "files_embargoed_bsi:*",
        "toc_embargoed_bsi:*"
      ],
      "q": "has_model_ssim:Etd",
      "indent": "true",
      "q.op": "OR",
      "rows": "0",
      "facet": "true"
    }
  },
  "response": {
    "numFound": 12652,
    "start": 0,
    "maxScore": 2.7608676,
    "numFoundExact": true,
    "docs": [

    ]
  },
  "facet_counts": {
    "facet_queries": {
      "abstract_embargoed_bsi:*": 12652,
      "files_embargoed_bsi:*": 12652,
      "toc_embargoed_bsi:*": 12652
    }
  }
}

_TESIM

// 20240923113202
// http://localhost:8993/solr/laevigata/select?facet.query=abstract_embargoed_tesim%3A*&facet.query=files_embargoed_tesim%3A*&facet.query=toc_embargoed_tesim%3A*&facet=true&indent=true&q.op=OR&q=has_model_ssim%3AEtd&rows=0

{
  "responseHeader": {
    "status": 0,
    "QTime": 3,
    "params": {
      "facet.query": [
        "abstract_embargoed_tesim:*",
        "files_embargoed_tesim:*",
        "toc_embargoed_tesim:*"
      ],
      "q": "has_model_ssim:Etd",
      "indent": "true",
      "q.op": "OR",
      "rows": "0",
      "facet": "true"
    }
  },
  "response": {
    "numFound": 12652,
    "start": 0,
    "maxScore": 2.7608676,
    "numFoundExact": true,
    "docs": [

    ]
  },
  "facet_counts": {
    "facet_queries": {
      "abstract_embargoed_tesim:*": 0,
      "files_embargoed_tesim:*": 0,
      "toc_embargoed_tesim:*": 0
    }
  }
}
coveralls commented 1 month ago

Coverage Status

coverage: 96.449% (+0.2%) from 96.254% when pulling 4a9c6effc18964c6885d17859c2b20de0657c923 on dead_code into ec4e6d0d2660cd1d146805d4a51ac9398fb16a95 on main.