search

curationexperts / laevigata

A Hyrax-based ETD repository including deposit workflow
Other
5 stars 4 forks source link

[FIX] Fix flaky embargo tests #2441

Closed mark-dce closed 1 month ago

mark-dce commented 1 month ago

ISSUE The embargo specs fail intermittently when run in the full suite.

DIAGNOSIS Depending on the randomized test order, the admin tests may run before the regular user tests. In some test orders, the admin user may remain logged in while the tests for regular users are run resulting in admin-only data being rendered in the views.

FIX Explicitly log out any user from a previous test when testing regular or unauthenticated user views.

coveralls commented 1 month ago

Coverage Status

coverage: 91.799% (-1.4%) from 93.178% when pulling 71006ca30b0548d2c6cd42a835f01f069d907519 on fix_flaky_test into 41043dc0e3f5661c05b4eb6857e8f51d0343ad42 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 96.734% (+3.6%) from 93.178% when pulling 71006ca30b0548d2c6cd42a835f01f069d907519 on fix_flaky_test into 41043dc0e3f5661c05b4eb6857e8f51d0343ad42 on main.