This commit adds the pdf.js library

curationexperts / mahonia

Oregon Health & Science Repository

Apache License 2.0

6 stars 0 forks source link

This commit adds the pdf.js library #175

Closed little9 closed 6 years ago

little9 commented 6 years ago

… and the viewer from Firefox to to the application in the /public directory. The viewer needs to be hosted statically.

This also adds a 'View Document' button to the show page that links to the portion of the page where the viewer is displayed.

Closes #14

coveralls commented 6 years ago

Coverage remained the same at 96.211% when pulling 275bb7273dd3455fe6fd3d54bb140a49bc163782 on feature/pdf-viewer into ae49d7cdd7f49064bedbddcce8d738991ee4c805 on master.

coveralls commented 6 years ago

Coverage remained the same at 96.211% when pulling 4d63b22b618ed7cf1bff0b491ff83556106ef316 on feature/pdf-viewer into ae49d7cdd7f49064bedbddcce8d738991ee4c805 on master.

coveralls commented 6 years ago

Coverage remained the same at 96.211% when pulling c78902ac96b20967304274be7c04a69c16858a7b on feature/pdf-viewer into ae49d7cdd7f49064bedbddcce8d738991ee4c805 on master.

no-reply commented 6 years ago

Are the views/partials included in this PR copied in from Hyrax?

I think it would help in future upgrades for the commit history to reflect the copy-in separate from the changes specific to this feature. Should we adopt a practice of including a commit that copies views and partials in exactly (maybe with a note about which commit/tag of Hyrax they are copied from), separate form any changes we may actually want to make?

little9 commented 6 years ago

@no-reply I went back and added a commit that includes links to the sources for the overrides.

coveralls commented 6 years ago

Coverage remained the same at 96.211% when pulling 542365b16b41656be933cc125a4f40d4cf7422a8 on feature/pdf-viewer into 72a63acc2393592c2ec19f6c3bdb4b8331605159 on master.