curationexperts / mahonia

Oregon Health & Science Repository
Apache License 2.0
6 stars 0 forks source link

testing create and show feature with full metadata #198

Closed jenlindner closed 6 years ago

jenlindner commented 6 years ago

Fixes #166

This commit audits the metadata used to create an OSHU Etd, by creating an Etd with a complete set of the displayable metadata and visiting its show page to confirm it. It also separates the edit spec into its own file, which takes advantage of the database cleaning that occurs between rspec suites and is easier to manage. It also fixes a bug uncovered by the feature spec, in which single-valued fields were sent to the back end as strings, which meant they were considered unpermitted parameters by the hyrax gem. The fix wraps single-value inputs in arrays, and was first implemented in Laevigata.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 96.629% when pulling 556e40edfaeb9a5cedc30ac4984d88f6b0ae083c on create-etd-feature-spec into 60679df37c4bc9502c9ecb035f40b7cdab7315a3 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 96.629% when pulling e3a39760fd652da8fb03d106d5011da8c1f4be54 on create-etd-feature-spec into 60679df37c4bc9502c9ecb035f40b7cdab7315a3 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 96.296% when pulling e3a39760fd652da8fb03d106d5011da8c1f4be54 on create-etd-feature-spec into 60679df37c4bc9502c9ecb035f40b7cdab7315a3 on master.