search

curationexperts / mahonia

Oregon Health & Science Repository
Apache License 2.0
6 stars 0 forks source link

Importer with validator - wip approach #240

Closed jenlindner closed 6 years ago

jenlindner commented 6 years ago

This commit builds on the importer by including a Mahonia validator (and the DarlingtoniaValidator shared example test, which it probably shouldn't in the long term). The validator expects a metadata hash and checks for title, returns an array with a Darlingtonia error in it if title is missing. It's called from the MahoniaMapper, which might not be the best place for validation, and nothing reacts to it yet.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-30.4%) to 68.071% when pulling ab974286a69202eaec829165c2cfd78e5a6cdf04 on importer-with-validator into e7d30163ed71d590cc647d3b6a45ecf855dd4d38 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 98.223% when pulling 6fa4758a171d282dd58bc89901722663012e534c on importer-with-validator into e7d30163ed71d590cc647d3b6a45ecf855dd4d38 on master.