search

curationexperts / mahonia

Oregon Health & Science Repository
Apache License 2.0
6 stars 0 forks source link

Skip records with no data on import #248

Closed no-reply closed 6 years ago

no-reply commented 6 years ago

Our sample BePress exports contain rows with only delimiters. Rather than fail validation on these rows, we prefer to skip them entirely. We do this at the Parser layer, so anything consuming Parser#records (validators, importers, etc...) will treat these rows as non-records.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 97.76% when pulling 43b6d1cf37a4d66f44bce61382f333ab400c2861 on skip-empty-records into ee469b7e86fa56a6d6d24e0607aa2bc446f8430a on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 97.76% when pulling 43b6d1cf37a4d66f44bce61382f333ab400c2861 on skip-empty-records into ee469b7e86fa56a6d6d24e0607aa2bc446f8430a on master.

no-reply commented 6 years ago

Is the commit message what you want it to be?

Something happened with the GitHub form, I fixed the PR message. I think the commit message is correct.

no-reply commented 6 years ago

Sorry @jenlindner, I pushed up a spec commit which dismissed your review.

jenlindner commented 6 years ago

No problem, looks great!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.007%) to 97.92% when pulling 4de8db143225813d0b5ffd0b95db18c9d75542ac on skip-empty-records into ee469b7e86fa56a6d6d24e0607aa2bc446f8430a on master.