search

curationexperts / mahonia

Oregon Health & Science Repository
Apache License 2.0
6 stars 0 forks source link

Add Rights Note field #92

Closed no-reply closed 7 years ago

no-reply commented 7 years ago

This adds a Schema::CoreMetadata class to hold general OHSU metadata and adds the rights_note to it. Schema::CoreMetadata is then included in Etd.

The rights note is added to the EtdForm, and various tests are added to ensure correct behavior.

Closes #59.

no-reply commented 7 years ago

@mark-dce I have rebased this.

mark-dce commented 7 years ago

@no-reply This looks great and reads nicely. I'm thinking we're going to hit the same type of merge conflicts though as we do the remaining fields.

Can you

  1. resolve the specific conflicts here and I'll merge in the morning
  2. think about how we want to handle this in the future. I'd be ok with layering each new field on the branch containing the previous and being sure we merge in submission order. It is nice being able to do the review for changes related to each new term independently, so I don't think I'd want to batch terms together.
no-reply commented 7 years ago

@mark-dce I'm generally fine rebasing before merge.

The conflicts for these PRs are going to be easily resolved in general and I think rebasing requires less coordination between developers than ensuring that we build from each other's branches.