search

curationexperts / trove

Digital Image Library based on Tufts repository models
0 stars 2 forks source link

Why do PersonalCollection and CourseCollection live in T-DIL instead of Tufts Models? #104

Closed mark-dce closed 10 years ago

jcoyne commented 10 years ago

Because they aren't used in any other project, and its makes development easier if they are in TDIL.

mark-dce commented 10 years ago

@jcoyne I see that, but if you're new to the code (me) It was a pain having to figure out what stuff came from CuratedCollection in tufts_models (which by your logic should still be in T-DIL) vs. what stuff was in Personal or Curated collection (which look like they have a fair bit of duplication that could maybe be refactored into CuratedCollection). By your logic, we should probably pull CuratedCollection back into T-DIL. That sort of feels contrary to the purpose of having a shared model gem though.

For instance, I think these changes probably should be in CuratedCollection but to your point, I was too lazy to put them there: https://github.com/curationexperts/tufts-image-library/blob/7fa02a0376233977a3d89c0230dc81dc22b04926/app/models/concerns/with_nested_members.rb#L4-L11

jcoyne commented 10 years ago

@mark-dce sounds good.