BUG: urls don't indicate wrong collection type

[mark-dce]

BUG In TDIL I can view the same user collection using either the Personal or Course collection paths. If I view under the wrong URL and change the type, bad things might happen...

http://tdil.curationexperts.com/course_collections/tufts.uc:8 - works http://tdil.curationexperts.com/personal_collections/tufts.uc:8 - works but should probably give me an error or, even better, just redirect to the correct url

QUESTION Is there really a reason we need personal and course collection classes - it seems like we might have much cleaner, clearer code if we just moved everything into CuratedCollection and just add a type attribute.

You'd need a .setType('personal' | 'course') method that was retracted to admins You'd need a way to express that only the creator or admins can make edits to a CuratedCollection. You'd need to slightly modify the Course and Personal collection logic for the sidebar display

I don't see any other differences between the two.

ACCEPTANCE

• [ ] Give a redirect if someone tries to view a collection from the wrong path

[jcoyne]

No. You just enumerated a bunch of differences, then you said, "I don't see a difference"

[jcoyne]

This is a problem with every project that is using ActiveFedora, because each repository object can theoretically be of more than one type. This suggests the solution to this issue ought to be in Hydra or ActiveFedora because it affects more than just collections. You can do the same with a TuftsPdf pid on the TuftsImageController, etc.

[mark-dce]

After team discussion, we decided to leave the models as-is and just add a redirect if you try to access via an inconsistent path.