curationexperts / trove

Digital Image Library based on Tufts repository models
0 stars 2 forks source link

TDIL & MIRA should support tufts Art & Art History pid formats #175

Closed mark-dce closed 10 years ago

mark-dce commented 10 years ago

ISSUE pid's with dashes are not handled gracefully. It appears that you can create them, but they break search, track, show, etc.

Steps to reproduce

EXAMPLE PIDS pid + link to live object in production repo tufts:aah.slidelib.1127-9 - http://repository01.lib.tufts.edu:8080/fedora/objects/tufts:aah.slidelib.1127-9 tufts:aah.slidelib.0285-32 - http://repository01.lib.tufts.edu:8080/fedora/objects/tufts:aah.slidelib.0285-32

There appear to be a very large number of pids with this format: the majority of the ARTIFACT images appear to be stored in Fedora and use pids similar to these.

These cause issues both because of pid filtering on the string aah - see #174 - and because dashes aren't currently supported in routes.

mark-dce commented 10 years ago

@acozine we should try to set up a call with Mike K. before the demo to talk through this issue and #174. It's unclear to me whether Tufts will be using PIDs with this format in MIRA or TDIL. If not, then this doesn't need to be high-piority any more.

jcoyne commented 10 years ago

I don't think this is an issue in TDIL (see a1309b7), only MIRA. Fixed that with https://github.com/curationexperts/mira/commit/94819ea4e8bf099edb3e4eab94db637eaf19cbb8