search

curationexperts / trove

Digital Image Library based on Tufts repository models
0 stars 2 forks source link

Collections: make 'back to search' behave in a consistent manner #26

Closed mark-dce closed 10 years ago

mark-dce commented 10 years ago
mark-dce commented 10 years ago

Promoting to a bug because of the following behavior:

  1. Click on 'Home' or the 'Tufts Digital Image Library' target to clear active searches
  2. Click on any course or personal collection to view it
  3. Click on 'Back to Search'

To a normal user, 'Back to Search' doesn't appear to do anything because it's target is set to the collection pid.

jcoyne commented 10 years ago

The problem here is that "Home" is not a search, it's just a static page. It doesn't clear anything. When you click "back to search", you go to your last stored search.

jcoyne commented 10 years ago

Should we make the home page visit act as a recorded "search"?

bmaddy commented 10 years ago

Those questions are for @mark-dce

mark-dce commented 10 years ago

I just realized this only happens on new browser sessions.

I'm really open to you using your creativity here - the behavior I'm objecting to is having the "back to search" button take me to the collection I'm viewing, which clearly isn't a search and isn't actually back to the thing I was viewing last.

The "back to search" can't just be the browser back button because if I click 'downgrade/upgrade to personal/course collection' or have just edited the title or description, the browser back still doesn't take me to a search page.

It seems overly complicated, but having CuratedCollectionsController#show set the last stored search to something generic if it's not already set could work fine

ACCEPTANCE

  1. When I clear my session data or open a new browser and visit the application root
  2. Then click on any personal or course collection link
  3. Then click on "Back to Search"
    • [ ] I should see the catalog index page for q='', fields='all_fields'
mark-dce commented 10 years ago

NOTE: Having just realized this only happens on brand new sessions, this is really minor, but I think this behavior makes the app look broken when it does occur. That being said, I'm willing to be overruled and close the ticket if the three of you don't agree with me and Tufts doesn't call this out as a bug to be fixed.

jcoyne commented 10 years ago

Ref https://github.com/projectblacklight/blacklight/pull/951