curationexperts / trove

Digital Image Library based on Tufts repository models
0 stars 2 forks source link

Grid View: make tile sizes consistent #57

Closed mark-dce closed 10 years ago

mark-dce commented 10 years ago

NOTE: currently, only items in collection show view do this correctly.

jcoyne commented 10 years ago

@mark-dce can you add a screenshot of what you are seeing?

jcoyne commented 10 years ago

Also: ensure that the grid display fills the whole frame on smaller displays.

jcoyne commented 10 years ago

It appears that the problem here is with the flex box stuff that @bmaddy added.

jcoyne commented 10 years ago

Sorry, it wasn't @bmaddy it was @cbeer.

jcoyne commented 10 years ago

screen shot 2014-08-27 at 4 33 55 pm @mark-dce How's this?

mark-dce commented 10 years ago

@jcoyne that's definitely an improvement. I'd still rather all the boxes are a standard width and all the boxes are a standard height - so in your example, row 2 would have the same height as row 1. We would need to truncate the title at two lines and description at something under 3 lines. Where we truncate, we should add '...' at the end to make it clear we're not showing the whole thing.

Same size across all rows and columns would be my preference, but if it's a total pain, go with the way you've got it in the wireframe.

jcoyne commented 10 years ago

@mark-dce a standard width is problematic as that will preclude a responsive design.

jcoyne commented 10 years ago

@mark-dce How about this:

screen shot 2014-08-29 at 11 00 22 am