search

cure-lab / MagicDrive

[ICLR24] Official implementation of the paper “MagicDrive: Street View Generation with Diverse 3D Geometry Control”
https://gaoruiyuan.com/magicdrive/
GNU Affero General Public License v3.0
664 stars 40 forks source link

Multi batchsize training. #101

Open Capchenxi opened 2 weeks ago

Capchenxi commented 2 weeks ago

To whom it may concern,

I have a problem when I change the train_batch_size into 2 in configs/runner/default_t.yaml file. The error occurs because of the line below https://github.com/cure-lab/MagicDrive/blob/cc9d9ae7931b2caf1ba2d304f460ba10e850fa31/magicdrive/networks/unet_addon_rawbox.py#L310C13-L310C43

I wonder if this line should be repeat_size = [repeat_size, 1] since the imported repeat_size as an integer is the batchsize, and 1 is the default uncond cam number.

Capchenxi commented 2 weeks ago

Or I wonder how to do multi-batchsize training for video generation since I still got errors when I fixed the line mentioned above. Thansk.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 7 days with no activity. If you do not have any follow-ups, the issue will be closed soon.

flymin commented 4 days ago

I do not think it is trivial to support multi-batch training, right now the video training only supports one video on one process. I sometimes use the "batch" dim as T, which is the frame number, to reuse the image generation code. I am sorry for the inconvenience. It may take some effort to support multi-batch training.