search

cure-lab / MagicDrive

[ICLR24] Official implementation of the paper “MagicDrive: Street View Generation with Diverse 3D Geometry Control”
https://gaoruiyuan.com/magicdrive/
GNU Affero General Public License v3.0
419 stars 22 forks source link

[unet-controlnet-question] Is the `ControlnetUnetWrapper` necessary? #34

Closed kandrio closed 4 weeks ago

kandrio commented 1 month ago

Good afternoon!

Is the ControlnetUnetWrapper object necessary here?

The self.unet weights are supposed to be already copied into the self.controlnet, here.

Therefore, why initialize a ControlnetUnetWrapper object, since you already have everything under self.controlnet?

Thank you, in advance

flymin commented 1 month ago

In some cases, you need to make only one single nn.Module for the whole project. Otherwise (also in case you do not know why you need it), it is useless.