search

cure-lab / SCINet

The GitHub repository for the paper: “Time Series is a Special Sequence: Forecasting with Sample Convolution and Interaction“. (NeurIPS 2022)
Apache License 2.0
617 stars 127 forks source link

Forward path retuns with None in case stack is > 2 #38

Open Pet222 opened 2 years ago

Pet222 commented 2 years ago

https://github.com/cure-lab/SCINet/blob/1a3f231a9c3e11c9a2ee384d3d19cbb5a2039ebb/models/SCINet.py#L373

In case the stack is > 2 it seems there is no return value given thus the forward path returns with None.

  1. unclear how the test in table-6 was performed for stack > 2 when it is not implemented in the repo
  2. suggestion: adding to the end of stack if-elif" a piece of code with "else raise NotImplementedError" would be useful.
VEWOXIC commented 2 years ago

Thanks for your asking. We will check this problem with the code we are running on.