curiosity-ai / catalyst

🚀 Catalyst is a C# Natural Language Processing library built for speed. Inspired by spaCy's design, it brings pre-trained models, out-of-the box support for training word and document embeddings, and flexible entity recognition models.
MIT License
715 stars 73 forks source link

In Language enum Luxembourgish is both 83 and 86 #34

Closed matteofabbri closed 4 years ago

matteofabbri commented 4 years ago

Language Luxembourgish

Describe the bug In Language enum Luxembourgish is both 83 and 86

83: Limburgan_Limburger_Limburgish, 86: Luxembourgish_Letzeburgesch,

theolivenbaum commented 4 years ago

Hi @matteofabbri - I'll try to move soon the remaining code that is outside of Catalyst (on https://www.nuget.org/packages/mosaik.core) - the Language enum will be one of them, and will do the fix then!

theolivenbaum commented 4 years ago

@matteofabbri just double checking, and it seems like wikipedia lists them both: https://en.wikipedia.org/wiki/Luxembourgish and https://en.wikipedia.org/wiki/Limburgish

If I'm not mistaken, the list of languages on the enum was auto-generated from this list: https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

matteofabbri commented 4 years ago

Cool, thanks. Talking about Mosaik.Core, i was trying to fix a couple of bug that causes deadlock in some enviroment like Microsoft Orleans, but the problem goes down inside the Mosaik.Core library and i dont find the code of that