search

curiosity-ai / catalyst

🚀 Catalyst is a C# Natural Language Processing library built for speed. Inspired by spaCy's design, it brings pre-trained models, out-of-the box support for training word and document embeddings, and flexible entity recognition models.
MIT License
715 stars 73 forks source link

Improve code quality #39

Closed iamcarbon closed 3 years ago

iamcarbon commented 4 years ago

This PR makes no functional changes and is focused on some minor cleanup.

iamcarbon commented 4 years ago

@theolivenbaum ready for review

iamcarbon commented 4 years ago

@theolivenbaum Quick ping.

theolivenbaum commented 4 years ago

Hi @iamcarbon!

Thanks for the pull request, can you also just add your contributors' agreement to the pullrequest under .github/contributors/iamcarbon.md? The template is available here.

Cheers,

Rafael

iamcarbon commented 4 years ago

@theolivenbaum Oh no. You may want to revisit the terms of the overly broad patent terms that force contributors to give up their rights to ALL their patents (and provide your company with perpetual rights to sublicense for free). Sadly, I'm unable to agree.

:(

--

"With respect to any patents you own, or that you can license without payment to any third party, you hereby grant to us a perpetual, irrevocable, non-exclusive, worldwide, no-charge, royalty-free license to:

make, have made, use, sell, offer to sell, import, and otherwise transfer your contribution in whole or in part, alone or in combination with or included in any product, work or materials arising out of the project to which your contribution was submitted, and

at our option, to sublicense these same rights to third parties through multiple levels of sublicensees or other licensing arrangements."

theolivenbaum commented 4 years ago

Hi @iamcarbon

I was actually surprised by your message, because it is a standard contributor agreement that is also used by other projects, such as spaCy .

Just to recap:

With respect to any patents you own, or that you can license without payment to any third party, you hereby grant to us a perpetual, irrevocable, non-exclusive, worldwide, no-charge, royalty-free license to:

make, have made, use, sell, offer to sell, import, and otherwise transfer your contribution in whole or in part, alone or in combination with or included in any product, work or materials arising out of the project to which your contribution was submitted, and

at our option, to sublicense these same rights to third parties through multiple levels of sublicensees or other licensing arrangements.

I think you're misunderstanding the broadness of this clause. The rights to use the patents only applies in relation to the code contribution you would be submitting - obviously this does not give us any rights to use your patents outside of the scope of the code you would contribute - i.e. if you have a completely unrelated patent to the code you would be contributing...

iamcarbon commented 4 years ago

I think you are right (in my misunderstanding). And agree 100% on the intent / purpose of ensuring that related patents rights are granted to projects with contributions. Giving this another read!