curiosity-ai / h5

🚀 The next generation C# to JavaScript compiler
https://github.com/curiosity-ai/h5
Apache License 2.0
211 stars 30 forks source link

Locales not supported #44

Closed vladimir-angelov-1337 closed 2 years ago

vladimir-angelov-1337 commented 3 years ago

image

My h5.json:

{
    "output": "../Shoptico.Core.Backend/wwwroot/$(AssemblyName)/",
    "sourceMap":
    {
        "enabled": false
    },
    "reflection":
    {
        "disabled": false
    },
    "locales": "en-US;en-GB;bg-BG", //if I keep this - I get the crash, if I remove it - it's okay
    "generateTypeScript": false,
    "cleanOutputFolderBeforeBuild": true,
    "logging":
    {
        "level": "None"
    },
    "loader":
    {
        "type": "ES6",
        "manualLoading": true,
        "skipManualVariables": true
    },
    "htmlx":
    {
        "keepJSDependencies": true
    }
}
theolivenbaum commented 3 years ago

Hi @TriEdgeAI - what does locales do on Bridge? I've never used it and I think I had removed it when doing the fork. Happy to add it back if useful

vladimir-angelov-1337 commented 3 years ago

It allows you to use CultureInfo essentially with locales other than InvariantCulture.

theolivenbaum commented 2 years ago

@TriEdgeAI finally got some time to check this! Latest version of h5 will now embed the locale files correctly

vladimir-angelov-1337 commented 2 years ago

Just checked, seems to be working, will report whether I managed to build our entire codebase a bit later.