curiosity-ai / h5

🚀 The next generation C# to JavaScript compiler
https://github.com/curiosity-ai/h5
Apache License 2.0
210 stars 30 forks source link

Fixing UpdateH5 logic in Sdk.targets #85

Open mjrist opened 1 year ago

mjrist commented 1 year ago

It was not possible to set UpdateH5 to false to disable the update of the global h5 compiler when not using the compilation server.

This change updates the checks to make this possible.

Summary of the updated behavior:

If using the global compiler and it is not installed, UpdateH5 gets set to true so that it gets installed. (Now this simply calls h5 instead of h5 check-if-online which would return non-zero if the server was not running even though h5 was installed.)

If using the global compiler and it is installed, then do whatever is indicated by UpdateH5.

If using the local compiler always set UpdateH5 to false - never update or install.

mjrist commented 1 year ago

@theolivenbaum any thoughts on this change? I'm open to suggestions. I've tested this out and it works great for us. We would love to see this merged in.