curiosity-ai / rocksdb-sharp

.net bindings for the rocksdb by facebook
BSD 2-Clause "Simplified" License
155 stars 38 forks source link

No OSS license? #29

Closed thedevopsmachine closed 1 year ago

thedevopsmachine commented 2 years ago

Hey team, I was hoping to use this project for something I'm working on, but since it doesn't have an OSS license assigned, I'm not allowed to. Without explicitly assigning a license, we have to treat it as if it has the most restrictive license.

Can you please assign an OSS license to the project? Preferably something open like Apache 2.

Thanks very much

dahlia commented 1 year ago

It seems the 2-Clause BSD:

https://github.com/curiosity-ai/rocksdb-sharp/blob/d131cb7dec4fabeb6809e8dd759aad4be4480596/csharp/RocksDbSharp.csproj#L15

However, it would be good to have a COPYING or LICENSE file.

thedevopsmachine commented 1 year ago

Thanks!

queequac commented 1 year ago

@theolivenbaum The underlying native RocksDB library has a dual-license, where you can choose between GPLv2 and Apache 2.0.

Is there a reason why your nuget-package states BSD-2-Clause? For simplicity you might consider switching also to Apache 2.0, which would ease clearing apps using your package. (As a dependency, Facebook's RocksDB license will be pulled in anyway.)

And as @dahlia suggests, please add a LICENSE file to the code base, so GitHub will automatically add the license info to the project infos.

theolivenbaum commented 1 year ago

Can't believe I've never noticed this. I'll fix asap!

theolivenbaum commented 1 year ago

Fixed by b774336a37d8da75ae1b292ab09fc5acdb5a1c6a. Unfortunately I can't change the license without the permission from the original author. But the current license is the BSD-2-Clause, so should be fine for your use