search

curiosity-ai / rocksdb-sharp

.net bindings for the rocksdb by facebook
BSD 2-Clause "Simplified" License
163 stars 41 forks source link

AZ Sub Id Exposure #38

Closed ByronAP closed 1 year ago

ByronAP commented 1 year ago

You really should not expose your AZ sub id and other credentials for the curiositydev account, you should use secrets instead.

theolivenbaum commented 1 year ago

Hi @ByronAP, as far as I know, the sub id is not considered something that needs to be kept secret. https://learn.microsoft.com/en-us/answers/questions/340725/is-subscription-id-personal-or-should-be-kept-priv

https://stackoverflow.com/questions/45661109/are-azure-subscription-id-aad-tenant-id-and-aad-app-client-id-considered-secre