search

curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-1938] [Mantis 1974] Unclear Problem message placing object in variable room #146

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : dfremont

Description :

If you try to place an object in a room given by a variable, the unhelpful Problem message below results.

Since this seems like an easy mistake to make, I was going to suggest adding a note in this situation saying that you can only use a single, concrete room - but that appears not to be the case! If you specify an initial value for the variable, compilation succeeds. So I'm not sure what the desired behavior is.

I also note that the same Problem message occurs when the location is given by a constant with an undefined value - this should presumably be handled differently.

Steps to reproduce :

Foo is a room.
Quog is a room that varies.
[Quog is initially Foo.]
[Quog is always troggle.]
The player is in Quog.

Additional information :

The Problem message:

Problem. You wrote 'The player is in Quog' : but that is an assertion I can't puzzle out, which seems to involve placing two things in some sort of relationship, but if so then I can't make it work. Perhaps the sentence is too complicatedly phrased, and could be broken up into two or more sentences?

imported from: [Mantis 1974] Unclear Problem message placing object in variable room
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-12T08:44:56+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

61eedb62875fc10070240916:

Fixed via this commit: https://github.com/ganelson/inform/commit/a90345311637e5b1383c359a26349bfdf8d80e4f

Comment by Graham Nelson:
This is pretty marginal - the original problem message wasn't so unreasonable, and the situation is not a common one. However, it was simple enough to add two special-case problem messages.