curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-2067] [Mantis 2104] WwI §9.2 recommends awarding points in a way that doesn't work #17

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : mattweiner

Description :

WwI §9.2, on awarding points, recommends the following:

After taking the trophy when the trophy is not handled:
increase the score by 5;
say "Well done!"

However this will not work in 6M62, as in 6M62 the trophy will be set to "handled" during the carry out taking phase (by the "standard taking rule"), and so the check for whether it is not handled will fail in the After phase. The rule should say "was handled."

Steps to reproduce :

Use scoring.

Lab is a room. A trophy is in Lab. A diamond is in Lab.

After taking the trophy when the trophy is not handled: 
    increase the score by 5; 
    say "Well done!"

After taking the diamond when the diamond was not handled: 
    increase the score by 5; 
    say "Very well done!"

test me with "take trophy/take diamond".

Additional information :

Forum thread: https://intfiction.org/t/scoring-based-on-handled-property-not-working-in-7-9-3-build-6m62/41968

imported from: [Mantis 2104] WwI §9.2 recommends awarding points in a way that doesn't work
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-10T04:37:18+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

61eedb62875fc10070240916:

Fixed via this commit: https://github.com/ganelson/inform/commit/7b361ce67921e3526e2baf96eed409768fbabf93