curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-1909] [Mantis 1945] Move responses to some verbs completely in language files #175

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : hugolabrande

Description :

The responses to LMode1, LMode2, LMode3, and ScriptOn verbs are not fully contained in the language file (say, English.h). Instead, they print something from English.h, and something else (the name of the game, or the version for ScriptOn).

Could the calls to "print (string) Story" (line 2214, 2216, 2218) and "VersionSub" (line 1176) be moved to English.h (line 993, 997, and 1001, and line 1287) ? This would make it easier to change these messages (no need to change verblib) and give control of the whole printed messages from the language files (as it should be).

Thanks!

Steps to reproduce :


Additional information :

imported from: [Mantis 1945] Move responses to some verbs completely in language files
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-07T05:01:50+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by DavidG :
I see there are other instances of English words printed in verblib.h that probably could be moved to english.h

curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by DavidG :
Written up at https://gitlab.com/DavidGriffith/inform6lib/issues/50

curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by DavidG :
Done. What remains are debug messages. These can stay in English because debug messages are for authors and an author needs to know English in order to write programs in Inform 6.

Fixes are in https://gitlab.com/DavidGriffith/inform6lib/commit/4fb800dc00b9e1a99856d92edb3edb0948fe715e and https://gitlab.com/DavidGriffith/inform6lib/commit/16fb29482b8cf26eb6d193ef75f5530db25f4e49