curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-1904] [Mantis 1940] Abject "parse tree broken" error with table column named "topic" #180

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : dhakajack

Description :

I added the column "topic (text)" to the following table:

Table of Inventory
pN (a pType) wounded (a truth state) defending (a room) topic (a text)
with 100 blank rows.

At compile, the IDE produce the following error message:

An internal error has occurred: Parse tree broken. The error was detected at line 1656 of "inform7/Chapter 13/Parse Tree.w". This should never happen, and I am now halting in abject failure.

I think the problem is actually a name space collision with a similarly named column in an extension. Changing the name to "topicLookup (a text)" made inform happy enough to compile. I'm just flagging this in case the error message could be tweaked to be more informative. Thanks!

Steps to reproduce :

Kitchen is a room.

Table of Inventory
topic (text)
"x"

----------------------- user's original example:

Table of Inventory
pN (a pType)    wounded (a truth state) defending (a room)  topic (a text)
with 100 blank rows.

Additional information :

"test" by Welch, Jack [E]

Example Location is a room.

Table of Inventory
wounded (a truth state) defending (a room) topic (a text)
with 100 blank rows.

imported from: [Mantis 1940] Abject "parse tree broken" error with table column named "topic"
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-13T12:34:50+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by zarf :
Looks related to http://inform7.com/mantis/view.php?id=1862 but I'm not sure if it's exactly the same problem.

curiousdannii-testing commented 2 years ago

61eedb62875fc10070240916:

Fixed via this commit: https://github.com/ganelson/inform/commit/db121fffcbc5007827012cb5645d289aee9f83df