curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-1819] [Mantis 1855] The output of the PLACES command has an extra newline after it #265

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : DavidG

Description :

From http://www.intfiction.org/forum/viewtopic.php?f=7&t=19461&p=105834#p105712

The output of the PLACES command has an extra newline after it. Using advent.z5 in the demos directory as an example:


ADVENTURE
The Interactive Original
By Will Crowther (1976) and Don Woods (1977)
Reconstructed in three steps by:
Donald Ekman, David M. Baggett (1993) and Graham Nelson (1994)
[In memoriam Stephen Bishop (1820?-1857): GN]

Release 9 / Serial number 060321 / Inform v6.33 Library 6/12-beta1 S

At End Of Road
You are standing at the end of a road before a small brick building. Around you
is a forest. A small stream flows out of the building and down a gully.

>places
You have visited: At End Of Road.

>

I see that in the beta library (and in lib 6/12 in the archive), in LanguageLM() in english.h, we have:


Places: switch

{ 1: print "You have visited: "; 2: ".^"; }

while in lib 6/11 in the archive, we have:


Places: switch

{ 1: print "You have visited: "; 2: print ".^"; }

I see minor differences in the 6/12 version of Places1Sub() in verblibm.h:


return L__M(##Places, 2)

when we reach the end of the list vs. the 6/11 version:

{ L__M(##Places, 2); return; }

but nothing that would obviously produce different numbers of newlines beyond what's in the L__M. So, I'm not sure what happened there between 6/11 and 6/12.

Steps to reproduce :


Additional information :

https://github.com/DavidGriffith/inform6lib/issues/26

imported from: [Mantis 1855] The output of the PLACES command has an extra newline after it
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-07T05:01:11+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by DavidG :
I think this is the result of some cleanups I did regarding excess newlines here and there and made things worse in a few places.