curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-1603] [Mantis 1639] The timed events rule can miss events just before midnight #481

Closed curiousdannii-testing closed 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : dfremont

Description :

The timed events rule doesn't take into account that 'the_time' wraps around at 1440, so if turns take more than 1 minute the rule can fail to detect events occurring shortly before midnight. The example below is the Example "Uptempo", with the times modified to produce the bug.

Steps to reproduce :

The fast time rule is listed before the timed events rule in the turn sequence rules.
The advance time rule is not listed in the turn sequence rules.
This is the fast time rule:
    increment the turn count;
    increase the time of day by 15 minutes.
When play begins: now the right hand status line is "[time of day]".
The Temporal Hot Spot is a room.
The time of day is 11:45 PM.
At 11:58 PM: say "Two turtles run by, almost too fast to see."
At 12:02 AM: say "The grass grows."
Test me with "z / z".

Additional information :

imported from: [Mantis 1639] The timed events rule can miss events just before midnight
  • status: Closed
  • resolution: Resolved
  • resolved: 2022-04-07T04:59:41+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by graham :
Fair enough: there seems no reason for midnight to be special, so I've fixed this. There was nothing in the documentation to cover what happens when rules are passed over by time skips, so I've added something there too.