search

curiousdannii-testing / inform7-imported-bugs

0 stars 0 forks source link

[I7-2021] [Mantis 2058] Multiple "take all" in an empty room causes a "Too many activities are going on at once." error. #63

Open curiousdannii-testing opened 2 years ago

curiousdannii-testing commented 2 years ago

Reported by : Marc

Description :

Issuing the command "take all" several times when there is nothing will raise a "Too many activities are going on at once." error.

Steps to reproduce :

The player is in a room.
Test me with "take all/take all/take all/take all/take all/take all/take all".

Additional information :

imported from: [Mantis 2058] Multiple "take all" in an empty room causes a "Too many activities are going on at once." error.
  • status: Reported
  • resolution: Open
  • resolved: 2022-04-07T05:02:35+10:00
  • imported: 2022/01/10
curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by zarf :
Confirmed.

In this situation, BeginActivity(DECIDING_WHETHER_ALL_INC_ACT) is called three times (per "TAKE ALL" command), but the corresponding EndActivity() call is never made. So the activity stack clogs up.

curiousdannii-testing commented 2 years ago

557058:4c095ffd-6d6f-47ce-9e73-77c613347b86:

Comment by zarf :
Note that this doesn't happen if the player is carrying some objects. Then the displayed message is "There are none at all available!" and the activity is properly closed. The problem only manifests if the room and player have no objects (and the displayed message is "You can't see any such thing.")