curiousdannii / parchment

The Interactive Fiction web app
https://iplayif.com
MIT License
421 stars 60 forks source link

TADS 2 games can't save/restore #138

Closed dfabulich closed 1 year ago

dfabulich commented 1 year ago

A user wrote in to the IFDB support mail reporting an issue with Unnkulian Underworld: The Unknown Unventure.

https://iplayif.com/?story=https%3A%2F%2Funbox.ifarchive.org%2F%3Furl%3Dhttp%3A%2F%2Fifarchive.org%2Fif-archive%2Fgames%2Fadventions%2Fadventions.zip%26open%3Duu1.gam

To repro:

GET LAMP
SAVE
RESTORE

The game that you saved won't appear on the list of saves to restore.

curiousdannii commented 1 year ago

Huh. That's very weird.

curiousdannii commented 1 year ago

I can see one issue, which is that when saving it uses the file usage "data", and when restoring it uses "save".

Now to determine why it would be doing that...

This seems to be a common problem - Babel also does the mix up. But terps like Gargoyle aren't affected. I'm going to ask on the forum if anyone has any advice.

https://intfiction.org/t/tads-2-savefiles-being-saved-as-datafiles/62083

curiousdannii commented 1 year ago

Chris Spiegel has identified the issue, which affects almost all TADS 2 interpreters. (It's surprising it doesn't affect some terps!)

https://github.com/tads-intfic/tads-runner/issues/30

curiousdannii commented 1 year ago

Fixed!