search

curiousdannii / parchment

The Interactive Fiction web app
https://iplayif.com
MIT License
424 stars 60 forks source link

Building zvm.debug.js? #33

Closed juhana closed 7 years ago

juhana commented 7 years ago

Gruntfile's concat task doesn't have rules to build zvm.debug.js. Is it intentional?

curiousdannii commented 7 years ago

Yeah sorry, it's halfway between one build system and another now (although I don't know what the final build system I want will be, maybe using gulp? Or make?) I think I want to shift to using browserify more.

Run npm run build-zvm before grunt.

juhana commented 7 years ago

Thanks, that works!

BroadcastGames commented 7 years ago

I tried with a fresh checkout from github today and it seems to fail for me on same zvm.debug.js

 > browserify src/ifvms.js/src/zvm.js --standalone ZVM > lib/zvm.debug.js

 Error: Cannot find module '/workdir/parchment/src/ifvms.js/src/zvm.js' from '/workdir/parchment'

Should I open a new issue?

curiousdannii commented 7 years ago

Probably that means the submodules aren't cloned. Run

git submodule init
git submodule update
BroadcastGames commented 7 years ago

That was it, missing submodules. Thank you.