curiousdannii / parchment

The Interactive Fiction web app
https://iplayif.com
MIT License
421 stars 60 forks source link

Very narrow windows cause "undefined" to be printed repeatedly #63

Closed peardox closed 2 years ago

peardox commented 5 years ago

Go here

http://iplayif.com/?story=http%3A%2F%2Fwww.ifarchive.org%2Fif-archive%2Fgames%2Fzcode%2Fcurses.z5

This is Graham Nelson's Curses

Now make your browser as small as possible and refresh the page

I mentioned this to you about 10 years ago

This is of little concern to me today but important to you

Once upon a time I intended to release an app...

curiousdannii commented 5 years ago

Can you explain a little more what the problem is? Can you provide a screenshot?

peardox commented 5 years ago

Sure = gimme a moment to do some ScreenShots

I'll BRB a I find the value in your work

Following - Screenshots

On Sat, Jan 26, 2019 at 12:13 AM Dannii Willis notifications@github.com wrote:

Can you explain a little more what the problem is? Can you provide a screenshot?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457778040, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejown907Pfa_y4LjSnV_qpyZnJ0Mj3ks5vG52cgaJpZM4aT1nC .

peardox commented 5 years ago

I'm sorry to have to give you the bad news and may be incorrect in my assumtions but it appears that the output of your Z5 is bad in the explicit case of a narrow screen - not worked out it it'd < 80 or < 40 yet - look it was ten years ago..

Here are the good + bad grabs

Full screen using Curses

[image: curses1.png]

I sort of hate to do the next image as I know how invested you are in this project

Shit - should I show you this one?

OK - I read your message, there will be a LOT of white space below

I respect your work, never forget that

White Space

More White Space

Even more White Space

Do you REALLY think it ends here?

Yep it does - this is your last chance to not read something

[image: curses2.png]

On Sat, Jan 26, 2019 at 1:50 AM Simon Booth simon@peardox.com wrote:

Sure = gimme a moment to do some ScreenShots

I'll BRB a I find the value in your work

Following - Screenshots

On Sat, Jan 26, 2019 at 12:13 AM Dannii Willis notifications@github.com wrote:

Can you explain a little more what the problem is? Can you provide a screenshot?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457778040, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejown907Pfa_y4LjSnV_qpyZnJ0Mj3ks5vG52cgaJpZM4aT1nC .

peardox commented 5 years ago

The white space was put there for a reason

I wanna do a web-based client using your superb code but when I hit < 32 this happens (this is from memory - 10 year ago)

I threw together a Cowther + Woods (worked) some 10 years ago to get him a BlackBerry 10

When I say I thew it together I word it correctly (four project in 2 days)

I've never forgotten Parchment as a result

I'd love to bring text adventures to today's phone obsessed crowd

On Sat, Jan 26, 2019 at 2:21 AM Simon Booth simon@peardox.com wrote:

I'm sorry to have to give you the bad news and may be incorrect in my assumtions but it appears that the output of your Z5 is bad in the explicit case of a narrow screen - not worked out it it'd < 80 or < 40 yet - look it was ten years ago..

Here are the good + bad grabs

Full screen using Curses

[image: curses1.png]

I sort of hate to do the next image as I know how invested you are in this project

Shit - should I show you this one?

OK - I read your message, there will be a LOT of white space below

I respect your work, never forget that

White Space

More White Space

Even more White Space

Do you REALLY think it ends here?

Yep it does - this is your last chance to not read something

[image: curses2.png]

On Sat, Jan 26, 2019 at 1:50 AM Simon Booth simon@peardox.com wrote:

Sure = gimme a moment to do some ScreenShots

I'll BRB a I find the value in your work

Following - Screenshots

On Sat, Jan 26, 2019 at 12:13 AM Dannii Willis notifications@github.com wrote:

Can you explain a little more what the problem is? Can you provide a screenshot?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457778040, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejown907Pfa_y4LjSnV_qpyZnJ0Mj3ks5vG52cgaJpZM4aT1nC .

curiousdannii commented 5 years ago

Please don't be silly, just explain what's going on. I can't see your screenshots. Were you trying to add them through replying to the email notification? I think you may need to add screenshots directly in the web page.

peardox commented 5 years ago

Sorry if my last explanation was "Silly", that was not the intent

Here's how to replicate this yourself

Go to http://iplayif.com/?story=http%3A%2F%2Fwww.ifarchive.org%2Fif-archive%2Fgames%2Fzcode%2Fcurses.z5

That works fine

Now resize your browser, width is the key here so make your browser an narrow as possible (height is not a concern from my observations)

I'm using Chrome which limits me to now narrow I can go but this applies to all browsers I've tried this on

Now you've got your super-thin browser load Curses again and you get something like this

[image: curses2.png]

I hope this explains things better and isn't considered "Silly"

When something goes wrong I want to replicate it myself as I can't see the issue myself otherwise

I did some work looking into this many years ago and it appeared to be the Z5 stuff at the time if that helps

On Sat, Jan 26, 2019 at 3:48 AM Dannii Willis notifications@github.com wrote:

Please don't be silly, just explain what's going on. I can't see your screenshots. Were you trying to add them through replying to the email notification? I think you may need to add screenshots directly in the web page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457798639, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejo4Ai9_ch8nRM_pCOaUR-iBWx0Yg4ks5vG9AMgaJpZM4aT1nC .

peardox commented 5 years ago

Oh, forgot to mention

The white space stuff was as I don't know if my replies are public or private

Hopefully the above message is a more straight forwards explanation

On Sat, Jan 26, 2019 at 12:40 PM Simon Booth simon@peardox.com wrote:

Sorry if my last explanation was "Silly", that was not the intent

Here's how to replicate this yourself

Go to http://iplayif.com/?story=http%3A%2F%2Fwww.ifarchive.org%2Fif-archive%2Fgames%2Fzcode%2Fcurses.z5

That works fine

Now resize your browser, width is the key here so make your browser an narrow as possible (height is not a concern from my observations)

I'm using Chrome which limits me to now narrow I can go but this applies to all browsers I've tried this on

Now you've got your super-thin browser load Curses again and you get something like this

[image: curses2.png]

I hope this explains things better and isn't considered "Silly"

When something goes wrong I want to replicate it myself as I can't see the issue myself otherwise

I did some work looking into this many years ago and it appeared to be the Z5 stuff at the time if that helps

On Sat, Jan 26, 2019 at 3:48 AM Dannii Willis notifications@github.com wrote:

Please don't be silly, just explain what's going on. I can't see your screenshots. Were you trying to add them through replying to the email notification? I think you may need to add screenshots directly in the web page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457798639, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejo4Ai9_ch8nRM_pCOaUR-iBWx0Yg4ks5vG9AMgaJpZM4aT1nC .

curiousdannii commented 5 years ago

None of your screenshots are displaying. Please go to the github website and post the screenshot directly.

peardox commented 5 years ago

Dannii

If you simply follow the text you can see it without screenshots

Can I simply ask what platform + browser you're using so I can compare results

I'll upload the image to my server - back in a mo

Don't forget the platform + browser stuff - it's important

On Sat, Jan 26, 2019 at 1:51 PM Dannii Willis notifications@github.com wrote:

None of your screenshots are displaying. Please go to the github website and post the screenshot directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457832742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejoxG0DLrg2YNbiroP17faTtE3DKpzks5vHF1MgaJpZM4aT1nC .

peardox commented 5 years ago

Here you go

Before https://perspak.com/tutes/curses1.png

After https://perspak.com/tutes/curses2.png

No secure cert for ifplay - this sucks (I can help)

As you obviously know the people at IFPlay so can I suggest that you recommend they take a peek at https://letsencrypt.org/ - I will warn you that this is not a foolproof system, it can screw up everything so DONT apply it to a live server without doing a staging server test first, then after that test do it on live.

If you can ask IFPlay what stack their on I can both test and confirm the safety - I'll just spin up a sever for a few hours and try the thing out. If they're using a LAMP (Linux, Apache, MySQL + PHP) I can almost say it's perfectly safe in advance. If they want me to test non-destuctively I'll need their co-operation and a chat with some techie their end.

Non LAMP servers - far harder

On Sat, Jan 26, 2019 at 1:59 PM Simon Booth simon@peardox.com wrote:

Dannii

If you simply follow the text you can see it without screenshots

Can I simply ask what platform + browser you're using so I can compare results

I'll upload the image to my server - back in a mo

Don't forget the platform + browser stuff - it's important

On Sat, Jan 26, 2019 at 1:51 PM Dannii Willis notifications@github.com wrote:

None of your screenshots are displaying. Please go to the github website and post the screenshot directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457832742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejoxG0DLrg2YNbiroP17faTtE3DKpzks5vHF1MgaJpZM4aT1nC .

peardox commented 5 years ago

Oops

wrong URLs

I mean these specific URLs

https://ifdb.tads.org/

and

http://iplayif.com/

The latter is the baddie - hope that's not you

Basically Google will de-list you next year

I'll take you a proper deploy and do a HTTPS on it - this will take me a while

On Sat, Jan 26, 2019 at 2:25 PM Simon Booth simon@peardox.com wrote:

Here you go

Before https://perspak.com/tutes/curses1.png

After https://perspak.com/tutes/curses2.png

No secure cert for ifplay - this sucks (I can help)

As you obviously know the people at IFPlay so can I suggest that you recommend they take a peek at https://letsencrypt.org/ - I will warn you that this is not a foolproof system, it can screw up everything so DONT apply it to a live server without doing a staging server test first, then after that test do it on live.

If you can ask IFPlay what stack their on I can both test and confirm the safety - I'll just spin up a sever for a few hours and try the thing out. If they're using a LAMP (Linux, Apache, MySQL + PHP) I can almost say it's perfectly safe in advance. If they want me to test non-destuctively I'll need their co-operation and a chat with some techie their end.

Non LAMP servers - far harder

On Sat, Jan 26, 2019 at 1:59 PM Simon Booth simon@peardox.com wrote:

Dannii

If you simply follow the text you can see it without screenshots

Can I simply ask what platform + browser you're using so I can compare results

I'll upload the image to my server - back in a mo

Don't forget the platform + browser stuff - it's important

On Sat, Jan 26, 2019 at 1:51 PM Dannii Willis notifications@github.com wrote:

None of your screenshots are displaying. Please go to the github website and post the screenshot directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457832742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejoxG0DLrg2YNbiroP17faTtE3DKpzks5vHF1MgaJpZM4aT1nC .

peardox commented 5 years ago

Told you this would take a while

https://if.peardox.com/

This is a GIT clone of Parchment and you'll notice it's secure

So - whoever owns http://iplayif.com/ needs to do the same to their site

If I leave my site up (I won't), this one is a special for you only to explain things

About 2010 I downloaded all the IF on IFDB

I can easily add every add all those to if.peardox.com (done it before - easy to do again) rather than redirect to DB

Gonna have to mail myself so you get a chance to see if.peardox.com (I'm actually interested in how it scales with such a crappy name)

Can we be friends now?

IF is low priority for me - I visit it very occasionally, sadly yesterday was my IF day...

I can help you if you desire, it should take less than a day for me to (maybe two) to sort things out

Should you desire my aid all you have to do us ask

I'm Simon Booth, my email is simon@peardox.com, I live in Manchester, UK. I have MANY friends who can do translation services - I simply need the English and Target language(s) - please bear in mind that I have to develop the tools to repack a Z5

On Sat, Jan 26, 2019 at 2:38 PM Simon Booth simon@peardox.com wrote:

Oops

wrong URLs

I mean these specific URLs

https://ifdb.tads.org/

and

http://iplayif.com/

The latter is the baddie - hope that's not you

Basically Google will de-list you next year

I'll take you a proper deploy and do a HTTPS on it - this will take me a while

On Sat, Jan 26, 2019 at 2:25 PM Simon Booth simon@peardox.com wrote:

Here you go

Before https://perspak.com/tutes/curses1.png

After https://perspak.com/tutes/curses2.png

No secure cert for ifplay - this sucks (I can help)

As you obviously know the people at IFPlay so can I suggest that you recommend they take a peek at https://letsencrypt.org/ - I will warn you that this is not a foolproof system, it can screw up everything so DONT apply it to a live server without doing a staging server test first, then after that test do it on live.

If you can ask IFPlay what stack their on I can both test and confirm the safety - I'll just spin up a sever for a few hours and try the thing out. If they're using a LAMP (Linux, Apache, MySQL + PHP) I can almost say it's perfectly safe in advance. If they want me to test non-destuctively I'll need their co-operation and a chat with some techie their end.

Non LAMP servers - far harder

On Sat, Jan 26, 2019 at 1:59 PM Simon Booth simon@peardox.com wrote:

Dannii

If you simply follow the text you can see it without screenshots

Can I simply ask what platform + browser you're using so I can compare results

I'll upload the image to my server - back in a mo

Don't forget the platform + browser stuff - it's important

On Sat, Jan 26, 2019 at 1:51 PM Dannii Willis notifications@github.com wrote:

None of your screenshots are displaying. Please go to the github website and post the screenshot directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/curiousdannii/parchment/issues/63#issuecomment-457832742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABejoxG0DLrg2YNbiroP17faTtE3DKpzks5vHF1MgaJpZM4aT1nC .

curiousdannii commented 5 years ago

Okay, yes I can see "undefined" being printed repeatedly. Very weird. You can't have reported that 10 years ago though because the code has been rewritten entirely since then.

https://iplayif.com/ is already secure. I'll see about redirecting http: later some time.

peardox commented 5 years ago

It wan't 10 years ago, more like 7 I guess - I know I first used Parchment in 2010

I noticed it at this point and did report it

The cool thing about letsencrypt is that it automates the redirect and you don't have to pay for a SSL cert - assuming you're using Apache, it's easy - other servers are more complicates). LetsEnctypt is well supported but you have to renew every 90 days (a trade off for a min's work)

i.e. you can HTTPS http://iplayif.com with a forced redirect very quickly (try it on a test server first!)

Googling you demotes ifplay since - err - bad memory, 2017 I think? Thinks get worse soon as well with Chrome I understand (Google suck)

curiousdannii commented 2 years ago

I think this is fixed now