curiousdannii / parchment

The Interactive Fiction web app
https://iplayif.com
MIT License
421 stars 60 forks source link

Depend on emglken via npm, not git submodules #77

Closed dfabulich closed 2 years ago

dfabulich commented 2 years ago

The web gulp task doesn't work unless you've inflated all of the git submodules with git submodule update --init --recursive; then you have to manually/separately run npm install in the src/upstream/emglken directory and npm run build. Then go grab a coffee… that build is gonna take a long time. It fires up a Docker instance to run a giant build script.

This is a very silly way to depend on emglken; emglken is available as an npm module. It should simply appear as an entry in package.json. (If you need to do local development of Parchment with emglken, developers can use npm link instead.)

curiousdannii commented 2 years ago

I really like my current setup though. But I can see that it would be much more straightforward for anyone else to use it this way.

I'll look into npm link and see if it will work for me.

However even if it does, there could be times when I make breaking changes to emglken upstream and there may be a little delay before I publish a version to npm.

curiousdannii commented 2 years ago

Thanks, you were right, this is a much better approach. Npm-linking is very easy.