curiouslearning / FeedTheMonsterJS

Javascript and HTML canvas exploration
MIT License
0 stars 4 forks source link

Run missing asset report on 20+ languages #486

Closed burrage closed 1 year ago

burrage commented 1 year ago

User Story As a developer and Product Owner, I want to run the JSON check and missing audio scripts on 20 languages to write a report on what we find if we were to try to build each of these languages, So that we can identify any further problems with being able to build these localizations.

Acceptance Criteria Given that I have run the JSON check and missing audio scripts on 20 language JSON files and for 20 language packs from GitHub and have recorded the results in the following Google Doc, When I view the doc, Then I can see what languages could be built without issue.

Language JSON files

Languages:

  1. Zulu

  2. Pashto

  3. Luganda

  4. Nepali

  5. Ukrainian

  6. Afrikaans

  7. Amharic

  8. Azerbaijani

  9. Bangla

  10. Australian English

  11. Indian English

  12. South African English

  13. West African (Nigerian) English

  14. Farsi

  15. Georgian

  16. Haitian Creole

  17. Hausa

  18. Igbo

  19. isiXhosa

  20. Javanese

    If we have time, remaining languages:

  21. Kinyarwanda

  22. Kiswahili

  23. Kurdish

  24. Malagasy

  25. Malay

  26. Marathi

  27. Ndebele

  28. Oromo

  29. SePedi

  30. Sesotho

  31. Shona

  32. Siswati

  33. Somali

  34. Spanish

  35. Tagalog

  36. Tajik

  37. Thai

  38. Tsonga

  39. Tswana

  40. Turkish

  41. Twi

  42. Urdu

  43. Venda

  44. Vietnamese

  45. Wolof

  46. Yoruba

burrage commented 1 year ago

@weepingwitch This report is still a work in progress, but the preliminary results we're seeing point to an issue with missing media assets that we should look into, given the prevalence.

I'm spinning up a separate task for the investigation but tagging here so we can keep apprised of when the report is done done.

burrage commented 1 year ago

@vinay961861 @Ashish1998 Just a heads up, we looked at Luganda, Afrikaans, and Australian English and found that the files should all be on the ftm_languagepacks repo. Do you know if the script checking for the media is case insensitive?

Is it also looking in multiple folders for the audio? Or just one? I know for our FTM web versions, we mentioned we would ultimately put everything into a single /audios/ folder, but on the ftm_languagepacks repo, we have multiple directories like "/Words/", "/Letters/", etc.

Ashish1998 commented 1 year ago

Hiii @burrage we noticed that the .wav extension is in upper and lower case so we got more issues, so now we updated the script. Even then we got some missing audios list, so the problem here was in the json it is showing as letters folder, but the audio is actually present in word folder.

divyahariharan2103 commented 1 year ago

Hey @burrage Any update on this ?

burrage commented 1 year ago

Which language should we look at for examples @Ashish1998 @divyahariharan2103 ? It sounds like we would need to re-generate the JSON with an updated path if that's the case.

@weepingwitch See above messages for JSON path confusion in the audio assets. We had decided to forego the more specific subfolders and lump everything together in a root .../[language]/audios/ folder to cutdown the onus on correctly filing each media asset-- with Stephanie, we determined there wouldn't be any overlap if we combined to one root folder.

burrage commented 1 year ago

Sorry, misunderstood what was written.

@weepingwitch , I see the JSONs have that agreed-upon path already .../[language]/audios/ so we are good there.

@Ashish1998 @divyahariharan2103 We'll need a task to consolidate existing subfolders of the audio we've downloaded into this root level .../[language]/audios/ structure. Does it make sense to do this physical consolidation as part of another process we already have? Like when we are converting the files to MP3?

burrage commented 1 year ago

@Rajesh1041 Mentioned we have this consolidation happening already so we do not need to make a new task. But we should re-run the reports!

Ashish1998 commented 1 year ago

Hiii @burrage we have updated the issue document. Please have a look into it. Thank you.