search

curiouslychase / _goorgeous

[DEPRECATED] A go org syntax parser to html
MIT License
160 stars 28 forks source link

v2 should work with Blackfriday v2 #71

Closed bep closed 5 years ago

bep commented 6 years ago

Your v2 tag still uses the old API, i.e.blackfriday.HtmlRenderer vs the new blackfriday.HTMLRenderer etc.

Probably not related, but you seem to use a very old version of Go Dep. They changed to a TOML file format a year ago.

curiouslychase commented 6 years ago

Thanks @bep, I'll look at it. I haven't used dep mgmt in go other than glide, but I thought I followed the docs. Sorry about that.

curiouslychase commented 6 years ago

Just an update, turns out I was using godep (https://github.com/tools/godep#how-to-use-godep-with-a-new-project) and not go dep (https://github.com/golang/dep). Updating now, will continue with changes tonight hopefully.

curiouslychase commented 6 years ago

Looking into it some this morning, this pkg really did do a major version change, looks like all of the public render methods are now private, so I'm going to have to figure out a way around that, but it'll def. be a blocker for moving to blackfriday v2.0.0.

bep commented 6 years ago

They have basically one RenderNode method now, but you can switch on the types. Maybe get some inspiration here:

https://github.com/Ambrevar/blackfriday-latex

curiouslychase commented 6 years ago

👍 just saw that as I was looking at how they're doing it. It'll still take some time, but that def. makes it better (and probably a better API anyways).

I've been working on a rewrite for using channels & AST, so this seems like something that'd dovetail into that. I'm going to reopen the issue you created and deprecate the v2.0.0 branch since it's not working and probably roll all of the work to convert in with the AST parser work I'm doing.

bep commented 6 years ago

No rush. I'm struggling with exactly the same trying to get Hugo over to the new API. The goorgeous import is just one of many temporary commented out sections ... When people open up an issue about "Hugo should update to Blackfriday v2" I suspect they think the amount of work is changing some import statement.

QuLogic commented 5 years ago

So it's been about a year, but I don't see any more recent commits?

curiouslychase commented 5 years ago

I had a branch I was getting ready to PR into Hugo this week that fixed this (no more dependency on Black Friday), but it looks like @niklasfasching PR'ed a new org parser, so I'm closing all the issues here, deprecating and archiving goorgeous.