search

curiouslychase / _goorgeous

[DEPRECATED] A go org syntax parser to html
MIT License
160 stars 28 forks source link

Allow blocks to be indented #73

Closed zzamboni closed 6 years ago

zzamboni commented 6 years ago

org-mode allows blocks to be indented, but the current goorgeous implementation recognizes them only at the start of the line. A simple change to the regex used to match blocks fixes this.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.828% when pulling 07588ca07229f58178454dfdd1aa29376095b5cf on zzamboni:fix-start-of-line-blocks into e0b2cd6d4e7abdf9a33f017bcc97df2242e05572 on chaseadamsio:master.

curiouslychase commented 6 years ago

thanks @zzamboni! do you mind adding at least one test to show it fixes the problem for indented blocks?

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.828% when pulling 9f73631ab97fbf2d7c48495be05f753d09cad984 on zzamboni:fix-start-of-line-blocks into e0b2cd6d4e7abdf9a33f017bcc97df2242e05572 on chaseadamsio:master.

zzamboni commented 6 years ago

Hi @chaseadamsio - I have added tests for indented code blocks mimicking the ones that were there for other blocks, and using varying amounts and types of indentation in each. go test seems to run OK but I'm not a Go coder so I'm not sure if I missed something.

curiouslychase commented 6 years ago

tests passed CI so that works for me.

Nice work on going above and beyond on adding tests!

nickanderson commented 6 years ago

+1